kvserver: deflake TestRequestsOnFollowerWithNonLiveLeaseholder #107442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They're too verbose and the metrics will already make it clear when things aren't set up properly.
This can be triggered rapidly because each replica might call this as it tries and fails to acquire a lease.
The `Inc` is the blocking part, so log before.
…eLeaseholder The test previously relied on aggressive liveness heartbeat expirations to avoid running for too long. As a result, it was flaky since liveness wasn't reliably pinned in the way the test wanted. The hybrid manual clock allows time to jump forward at an opportune moment. Use it here to avoid running with a tight lease interval. On my gceworker, previously flaked within a few minutes. As of this commit, I ran it for double-digit minutes without issue. Fixes cockroachdb#107200. Epic: None Release note: None
|
This change is |
erikgrinaker
approved these changes
Jul 26, 2023
It was actually useful to have this in the logs, since then it interleaves with the actual logs. Otherwise, you don't get timestamps and you're left wondering about the relative ordering. TFTR! bors r=erikgrinaker |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test previously relied on aggressive liveness heartbeat expirations to
avoid running for too long. As a result, it was flaky since liveness wasn't
reliably pinned in the way the test wanted.
The hybrid manual clock allows time to jump forward at an opportune moment.
Use it here to avoid running with a tight lease interval.
On my gceworker, previously flaked within a few minutes. As of this commit, I
ran it for double-digit minutes without issue.
Fixes #107200.
Epic: None
Release note: None